fix duplicate mention #19203

Parveshdhull · 2024-03-12T13:57:58Z

fixes #19124

Summary

For inline render components like mention we are nesting all views inside the text component. But parent text component has several limitations compared to the normal view component.

If the internal text component is directly nested, then we are not able to apply styles like border-radius
If we use a wrapper around that internal text component for styling, and if the internal text component rerenders due to content change then wrapper dimensions are not updated and cause issue
If we force the rerender wrapper too using key as resolved-mention then it loses positioning and will rerender at the start of the parent text
The only solution is force rendering of the parent itself.

Testing Note

Please also test follow up - The mention highlighted area is only updated after reopening the chat view when the name is updated #18432

status: ready

Parveshdhull · 2024-03-12T13:59:27Z

src/status_im/contexts/chat/messenger/messages/content/text/style.cljs

@@ -14,18 +14,18 @@

 (defn mention-tag-wrapper
  [first-child-mention]
-  {:flex-direction :row


revert of #19076

Parveshdhull · 2024-03-12T13:59:35Z

src/status_im/contexts/chat/messenger/messages/content/text/view.cljs

@@ -56,16 +56,14 @@
      :mention
      (conj
       units
-       (let [resolved-mention (rf/sub [:messages/resolve-mention literal])]


revert of #19076

Parveshdhull · 2024-03-12T13:59:54Z

src/status_im/contexts/chat/messenger/messages/content/text/view.cljs

@@ -107,6 +105,7 @@
                (render-inline acc e chat-id style-override mention-first))
              [quo/text
               {:size  :paragraph-1
+                :key   (rand-int 1000000) ;; https://github.com/status-im/status-mobile/pull/19203


only this change is new

status-im-auto · 2024-03-12T14:05:24Z

Jenkins Builds

Click to see older builds (11)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`9e0ec2b`	#2	2024-03-12 14:05:24	~5 min	`tests`	📄`log`
✔️	`9e0ec2b`	#2	2024-03-12 14:06:42	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`9e0ec2b`	#2	2024-03-12 14:07:06	~7 min	`android`	🤖`apk` 📲
✔️	`9e0ec2b`	#2	2024-03-12 14:12:22	~12 min	`ios`	📱`ipa` 📲

✔️	`90b6d9e`	#3	2024-03-20 12:13:30	~6 min	`tests`	📄`log`
✔️	`90b6d9e`	#3	2024-03-20 12:14:26	~7 min	`android`	🤖`apk` 📲
✔️	`90b6d9e`	#3	2024-03-20 12:14:32	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`90b6d9e`	#3	2024-03-20 12:15:59	~8 min	`ios`	📱`ipa` 📲

✔️	`fa3ab9f`	#4	2024-03-20 15:24:32	~7 min	`android`	🤖`apk` 📲
✔️	`fa3ab9f`	#4	2024-03-20 15:24:45	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`fa3ab9f`	#4	2024-03-20 15:26:59	~9 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`b099940`	#5	2024-03-20 15:45:26	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b099940`	#5	2024-03-20 15:45:34	~6 min	`android`	🤖`apk` 📲
✔️	`b099940`	#5	2024-03-20 15:47:40	~8 min	`ios`	📱`ipa` 📲

✔️	`640e91c`	#6	2024-03-20 15:58:02	~6 min	`tests`	📄`log`
✔️	`640e91c`	#6	2024-03-20 15:58:49	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`640e91c`	#6	2024-03-20 15:58:55	~7 min	`android`	🤖`apk` 📲
✔️	`640e91c`	#6	2024-03-20 16:01:16	~9 min	`ios`	📱`ipa` 📲

mohsen-ghafouri

LGTM

status-im-auto · 2024-03-13T10:41:42Z

81% of end-end tests have passed

Total executed tests: 48
Failed tests: 8
Expected to fail tests: 1
Passed tests: 39

IDs of failed tests: 702782,702777,703495,702855,702838,702807,702731,702730

IDs of expected to fail tests: 703503

Failed tests (8)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'new message' is under today
Device 2: Looking for a message by text: new message

critical/chats/test_public_chat_browsing.py:339: in test_community_message_send_check_timestamps_sender_username
    self.channel_2.verify_message_is_under_today_text(new_message, self.errors, 60)
../views/chat_view.py:1004: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element(timeout)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'new message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 1: Find Button by xpath: //*[@text="Paste"]
Device 1: Tap on found: Button

activity_center/test_activity_center.py:226: in test_add_contact_field_validation
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Error message is not shown for value "random string 123"

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` critical/chats/test_group_chat.py:459: in test_group_chat_mute_chat chat.long_press_element() ../views/base_element.py:323: in long_press_element action.long_press(element).release().perform() /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:174: in perform self._driver.execute(Command.TOUCH_ACTION, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace)) The element 'By.xpath: //[@content-desc='author-primary-name'][starts-with(@text,'kvnykrq')]/..' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception E Stacktrace: E io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //[@content-desc='author-primary-name'][starts-with(@text,'kvnykrq')]/..' is not linked to the same object in DOM anymore E at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122) E at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153) E at io.appium.uiautomator2.handler.Location.safeHandle(Location.java:23) E at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59) E at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277) E at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271) E at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435) E at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293) E at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267) E at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911) E at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) E at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611) E at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552) E at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466) E at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438) E at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140) E at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144) E at java.lang.Thread.run(Thread.java:1012) Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_join_send_text_messages_push, id: 702807
Device 1: Could not reach home view by pressing system back button Device 2: Could not reach home view by pressing system back button critical/chats/test_group_chat.py:79: in test_group_chat_join_send_text_messages_push [self.homes[i].navigate_back_to_home_view() for i in range(3)] critical/chats/test_group_chat.py:79: in <listcomp> [self.homes[i].navigate_back_to_home_view() for i in range(3)] ../views/base_view.py:408: in navigate_back_to_home_view while not self.chat_floating_screen.is_element_disappeared(1) \ ../views/base_element.py:231: in is_element_disappeared return self.wait_for_invisibility_of_element(sec) ../views/base_element.py:154: in wait_for_invisibility_of_element .until(expected_conditions.invisibility_of_element_located((self.by, self.locator))) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:86: in until value = method(self._driver) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:319: in _predicate target = driver.find_element(*target) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:409: in find_element return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value'] /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace)) An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up E Stacktrace: E UnknownError: An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up E at UIA2Proxy.command (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/jsonwp-proxy/proxy.js:355:13) E at processTicksAndRejections (node:internal/process/task_queues:95:5) E at AndroidUiautomator2Driver.helpers.doFindElementOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/lib/commands/find.js:30:10) E at doFind (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:36:17) E at wrappedCondFn (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:137:14) E at spin (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:221:20) E at waitForCondition (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:238:10) E at AndroidUiautomator2Driver.implicitWaitForCondition (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:139:12) E at AndroidUiautomator2Driver.findElOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:60:5) E at AndroidUiautomator2Driver.findElOrElsWithProcessing (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:60:12) E at AndroidUiautomator2Driver.findElement (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:75:12) Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 2: Find `OpenInStatusButton` by `xpath`: `//*[@text="Open in Status"]` Device 2: Tap on found: OpenInStatusButton `critical/chats/test_1_1_public_chats.py:178: in test_1_1_chat_emoji_send_reply_and_open_link self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) No reply received in 1-1 chat` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_edit_message, id: 702855
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:379: in test_1_1_chat_edit_message self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered") ../views/chat_view.py:243: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status)) Message status was not changed to Delivered, it's Sent` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_pin_messages, id: 702731
Device 1: Find `Button` by `xpath`: `//[@content-desc='pins-count']//android.widget.TextView` Device 2: Find `Button` by `xpath`: `//[@content-desc='pins-count']//android.widget.TextView` `critical/chats/test_1_1_public_chats.py:267: in test_1_1_chat_pin_messages self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Pinned messages count is 2 but should be 3 for user 2` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_message_reaction, id: 702730
Device 2: Wait for text element `EmojisNumber` to be equal to `1` Device 2: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` critical/chats/test_1_1_public_chats.py:64: in test_1_1_chat_message_reaction message_receiver.emojis_below_message(emoji="thumbs-up").wait_for_element_text(1, 90) ../views/base_element.py:181: in wait_for_element_text element_text = self.find_element().text.strip() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: EmojisNumber by xpath: `//[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (39)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-03-20T13:12:45Z

90% of end-end tests have passed

Total executed tests: 48
Failed tests: 4
Expected to fail tests: 1
Passed tests: 43

IDs of failed tests: 702777,702894,702850,703629

IDs of expected to fail tests: 703503

Failed tests (4)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Looking for community: 'open community'
Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented

critical/chats/test_public_chat_browsing.py:1180: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_public_chat_browsing.py:740: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) 1-1 chat from blocked user is not removed and messages home is not empty! E Message was not delivered after back up online.` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device 1: Find `Button` by `xpath`: `//*[@text="Paste"]` Device 1: Tap on found: Button `activity_center/test_activity_center.py:236: in test_add_contact_field_validation self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Error message is not shown for value "0x512543419b894307EA979C8d24219c279Be2315B"` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_contact_request_decline, id: 702850
Device 2: Find `Button` by `accessibility id`: `close-activity-center` Device 2: Tap on found: Button `activity_center/test_activity_center.py:94: in test_activity_center_contact_request_decline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Pending contact request is not shown on unread notification element on Activity center!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (43)

Click to expand

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-03-20T15:13:38Z

Hi @Parveshdhull !
Mentions are working correct now.
Thanks for your fix!

status-im-auto · 2024-03-20T16:27:17Z

0% of end-end tests have passed

Total executed tests: 8
Failed tests: 8
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 702855,702730,702731,702807,702838,702782,703495,702777

Failed tests (8)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Test setup failed: critical/chats/test_public_chat_browsing.py:284: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

Device sessions

Device 1:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_1_1_chat_message_reaction, id: 702730
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_1_1_chat_pin_messages, id: 702731
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
`Test setup failed: critical/chats/test_1_1_public_chats.py:20: in prepare_devices self.drivers, self.loop = create_shared_drivers(2) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`
2. test_group_chat_mute_chat, id: 703495
`Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices self.drivers, self.loop = create_shared_drivers(3) base_test_case.py:323: in create_shared_drivers raise e base_test_case.py:316: in create_shared_drivers test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1 '_asyncio.Future' object has no attribute 'session_id'`

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

Device sessions

Device 1:

Parveshdhull force-pushed the fix/mention-duplicate branch from 7635217 to 9e0ec2b Compare March 12, 2024 13:59

Parveshdhull commented Mar 12, 2024

View reviewed changes

Parveshdhull self-assigned this Mar 12, 2024

Parveshdhull requested review from flexsurfer and mohsen-ghafouri March 12, 2024 14:00

Parveshdhull added the request-manual-qa label Mar 12, 2024

mohsen-ghafouri approved these changes Mar 13, 2024

View reviewed changes

pavloburykh force-pushed the fix/mention-duplicate branch from 9e0ec2b to 90b6d9e Compare March 20, 2024 12:06

mariia-skrypnyk self-assigned this Mar 20, 2024

mariia-skrypnyk added the Tested - OK label Mar 20, 2024

Parveshdhull force-pushed the fix/mention-duplicate branch 2 times, most recently from fa3ab9f to b099940 Compare March 20, 2024 15:38

fix duplicate mention

640e91c

Parveshdhull force-pushed the fix/mention-duplicate branch from b099940 to 640e91c Compare March 20, 2024 15:51

Parveshdhull merged commit 5854a47 into develop Mar 20, 2024
6 checks passed

Parveshdhull deleted the fix/mention-duplicate branch March 20, 2024 16:01

fix duplicate mention #19203

fix duplicate mention #19203

Conversation

Parveshdhull commented Mar 12, 2024 • edited Loading

Summary

Testing Note

Parveshdhull Mar 12, 2024

Choose a reason for hiding this comment

Parveshdhull Mar 12, 2024

Choose a reason for hiding this comment

Parveshdhull Mar 12, 2024

Choose a reason for hiding this comment

status-im-auto commented Mar 12, 2024 • edited Loading

Jenkins Builds

mohsen-ghafouri left a comment

Choose a reason for hiding this comment

status-im-auto commented Mar 13, 2024

81% of end-end tests have passed

Failed tests (8)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (39)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

status-im-auto commented Mar 20, 2024

90% of end-end tests have passed

Failed tests (4)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (43)

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePR:

mariia-skrypnyk commented Mar 20, 2024

status-im-auto commented Mar 20, 2024

0% of end-end tests have passed

Failed tests (8)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Parveshdhull commented Mar 12, 2024 •

edited

Loading

status-im-auto commented Mar 12, 2024 •

edited

Loading